<html>
<head><meta charset="utf-8"><title>PRs approval requirement · t-compiler/wg-rustc-dev-guide · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/index.html">t-compiler/wg-rustc-dev-guide</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html">PRs approval requirement</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="199910666"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/199910666" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#199910666">(Jun 05 2020 at 17:44)</a>:</h4>
<p>I wonder what people think about the approval requirement we have for merging PRs</p>



<a name="199910692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/199910692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#199910692">(Jun 05 2020 at 17:44)</a>:</h4>
<p>I think I'd get rid of it</p>



<a name="199910761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/199910761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#199910761">(Jun 05 2020 at 17:45)</a>:</h4>
<p>there are PRs that just fixes typos and one need to approve to then merge</p>



<a name="199911193"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/199911193" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#199911193">(Jun 05 2020 at 17:48)</a>:</h4>
<p>CI is quick though</p>



<a name="199911228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/199911228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Léo Lanteri Thauvin <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#199911228">(Jun 05 2020 at 17:49)</a>:</h4>
<p>But, yeah, I’m bot sure the requirement is really useful</p>



<a name="199920719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/199920719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#199920719">(Jun 05 2020 at 19:03)</a>:</h4>
<p>I find it a bit helpful because I'm prone to fat-finger things/accidentally push to master/forget about my own PRs</p>



<a name="199920746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/199920746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#199920746">(Jun 05 2020 at 19:03)</a>:</h4>
<p>If everyone else finds it unhelpful, we can remove it</p>



<a name="201775888"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/201775888" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#201775888">(Jun 23 2020 at 20:08)</a>:</h4>
<p>By the way, just following up here</p>



<a name="201775908"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/201775908" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#201775908">(Jun 23 2020 at 20:08)</a>:</h4>
<p>Does anyone have a strong feeling here?</p>



<a name="201782969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs%20approval%20requirement/near/201782969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/196385-t-compiler/wg-rustc-dev-guide/topic/PRs.20approval.20requirement.html#201782969">(Jun 23 2020 at 21:04)</a>:</h4>
<p>I don't, I have a slight preference on let's get rid of the approval before thing</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>